build: 馃拹 incremental builds are idempotent #885
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this tweaks the `bindgen_rocksdb()` function in the build script so that it will only generate bindings to `/rocksdb/c.h` if the `bindings.rs` file does not already exist in the output directory.
cratelyn
force-pushed
the
kate/build-rs-does-not-regenerate-bindings
branch
from
5f1a423
to
cf0f2d7
Compare
|
i have reproduced the errors observed in CI. i am still hunting down a solution, but feel optimistic that i should be able to figure out how to avoid linking errors when compiling integration tests. i am going to mark this PR as a draft until i've pushed a commit addressing that. |
|
the issues appear to be related to the |
|
@cratelyn, any news? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this branch makes a collection of small tweaks to the
librocksdb-syscrate'sbuild script. these changes improve incremental builds of the library, by
adding conditional early returns that check if the rocksdb bindings, rocksdb
library, and snappy library have already been generated or compiled.
currently, repeated builds of the
librocksdb-syslibrary are never consideredfresh. for projects that rely on rocksdb as backing storage, this can create
a bottleneck in builds, and lead to spuriously recompiling dependent libraries.