Update duplicated 'when' clause warning message #10776
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously for duplicated when clauses like:
1: case foo
2: when :bar
3: when :baz
4: when :bar
5: end
You would get a warning like:
which is supposed to read as in:
"The 'when' clause at line 4 duplicates (conflicts) with (a 'when' clause at) line 2. This is ignored."
The issue is that it can be read as the clause on line 2 is ignored. This commit updates the warning message to instead say:
This makes it clear which clause is begin duplicated and which clause is being ignored.
This commit fixes both parsers.