-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aarch64: Save/Restore PAC keys #3569
base: master
Are you sure you want to change the base?
Conversation
Should fix #3568.
We'll look into getting a buildkite agent set up on an M1, so we can actually test this. |
Seeing the following test failures on an M1 with this PR on Fedora Asahi Remix, so I think it's mostly working:
|
I guess to fix |
From the testing that Ben did |
Friendly ping @Keno to possibly merge as is (existing tests that failed before on aarch64 now pass) and add follow-up PRs if/as necessary. |
I was hoping to get the M1 buildkite up, so we can actually test this. Let me follow up on that. |
@Keno Just wanted to ping about this. Is the testing infrastructure in place for this now? |
Ping; this also fixed my PAC issue. Note that in addition to the keys themselves, we'll also need to save/restore the key enabled state, which is available via |
Yup, fixing things here as well :) |
Should fix #3568.