Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(self-hosted): convert experimental vars to config options #29137

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

RahulGautamSingh
Copy link
Collaborator

@RahulGautamSingh RahulGautamSingh commented May 17, 2024

Changes

  • Converted the following experimental env vars to self-hosted config options
Env var Config option
RENOVATE_X_DOCKER_MAX_PAGES dockerMaxPages
RENOVATE_X_GITLAB_AUTO_MERGEABLE_CHECK_ATTEMPS gitlabAutoMergeableCheckAttempts
RENOVATE_X_GITLAB_BRANCH_STATUS_DELAY gitlabBranchStatusDelay
RENOVATE_X_GITLAB_MERGE_REQUEST_DELAY gitlabMergeRequestDelay
RENOVATE_X_PLATFORM_VERSION platformVersion

Context

Part of: #27879 (comment)

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

RENOVATE_X_GITLAB_AUTO_MERGEABLE_CHECK_ATTEMPS, RENOVATE_X_GITLAB_BRANCH_STATUS_DELAY, RENOVATE_X_GITLAB_MERGE_REQUEST_DELAY
docs/usage/self-hosted-configuration.md Show resolved Hide resolved
docs/usage/self-hosted-configuration.md Outdated Show resolved Hide resolved
docs/usage/self-hosted-configuration.md Outdated Show resolved Hide resolved
docs/usage/self-hosted-configuration.md Outdated Show resolved Hide resolved
docs/usage/self-hosted-configuration.md Outdated Show resolved Hide resolved
docs/usage/self-hosted-configuration.md Show resolved Hide resolved
docs/usage/self-hosted-configuration.md Outdated Show resolved Hide resolved
lib/config/options/index.ts Show resolved Hide resolved
@RahulGautamSingh RahulGautamSingh changed the title feat(self-hosted): convert experiemental vars to config options feat(self-hosted): convert experimental vars to config options May 17, 2024
lib/modules/platform/bitbucket-server/index.ts Outdated Show resolved Hide resolved
lib/modules/platform/gitlab/index.ts Show resolved Hide resolved
lib/modules/platform/gitlab/index.ts Outdated Show resolved Hide resolved
lib/modules/platform/gitlab/index.ts Outdated Show resolved Hide resolved
lib/modules/platform/gitlab/index.ts Outdated Show resolved Hide resolved
docs/usage/self-hosted-configuration.md Outdated Show resolved Hide resolved
docs/usage/self-hosted-configuration.md Outdated Show resolved Hide resolved
lib/config/options/index.ts Show resolved Hide resolved
lib/config/options/index.ts Outdated Show resolved Hide resolved
docs/usage/self-hosted-configuration.md Outdated Show resolved Hide resolved
lib/config/options/index.ts Show resolved Hide resolved
lib/modules/platform/gitlab/index.spec.ts Outdated Show resolved Hide resolved
lib/modules/platform/gitlab/index.ts Outdated Show resolved Hide resolved
RahulGautamSingh and others added 2 commits May 21, 2024 19:35
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
lib/modules/platform/gitlab/index.ts Outdated Show resolved Hide resolved
lib/modules/platform/gitlab/index.ts Outdated Show resolved Hide resolved
lib/modules/platform/gitlab/index.ts Outdated Show resolved Hide resolved
lib/modules/platform/gitlab/index.ts Outdated Show resolved Hide resolved
@RahulGautamSingh
Copy link
Collaborator Author

RahulGautamSingh commented May 28, 2024

Verified each migration locally, by logging the values of each option at runtime.
check 1: default values passed to functions ☑️
check 2: custom values, overwrites default values ☑️
check 3: old env vars parsed and then overwrite the default values ☑️

globalOnly: true,
},
{
name: 'gitlabAutoMergeableCheckAttempts',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rarkins @secustor I think we should unify this under a generic platform options object, so we've a single config option with known values. not is best time to do it.

WDYT?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand. Do you mean nesting it inside a platformOptions object? Does it give any advantage other than making sure all possible ones are located together within config?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants