docs(gitlab): add note about group access token rotation #29136
Merged
+21
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rarkins
reviewed
May 18, 2024
HonkingGoose
suggested changes
May 18, 2024
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
HonkingGoose
suggested changes
May 22, 2024
HonkingGoose
reviewed
Jun 7, 2024
HonkingGoose
approved these changes
Jun 7, 2024
rarkins
reviewed
Jun 7, 2024
HonkingGoose
reviewed
Jun 7, 2024
rarkins
approved these changes
Jun 8, 2024
|
🎉 This PR is included in version 37.399.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
viceice
requested changes
Jun 11, 2024
| - `read_api` | ||
| - `read_repository` | ||
| - `write_repository` (when using autodiscover) |
There was a problem hiding this comment.
why this is removed? autodiscover will check for write access and filter repo without this permission!
renovate/lib/modules/platform/gitlab/index.ts
Line 168 in f21efd3
There was a problem hiding this comment.
I tested autodiscover with read_api and read_repository and it was able to discover repositories.
min_access_level = 30 refers to the Developer role (https://docs.gitlab.com/ee/api/members.html#roles) which is the minimum requirement for the bot account.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds a note about rotating the group access token to keep the same bot user.
Also updated the required scopes (
apiallows one toread_user, and autodiscover uses the API soread_apiis sufficient).Context
See the discussion in #28736 (comment)
Closes #21121
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: