-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(datasource): sourceUrl
& releaseTimestamp
support
#29122
feat(datasource): sourceUrl
& releaseTimestamp
support
#29122
Conversation
sourcelUrl
& releaseTimestamp
supportsourcelUrl
& releaseTimestamp
support
sourcelUrl
& releaseTimestamp
supportsourceUrl
& releaseTimestamp
support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some common things to fix:
- Capitalizating abbreviations
- Grammar
Please check if my suggestions are good/bad before applying them.
Please also check the files I haven't commented on, I ran out of time. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add this to our docs in this PR or a separate one?
Separate would be better, as that will be a doc thing so the scope will change. |
@RahulGautamSingh please create a follow up Issue then for integrating this with the docs |
🎉 This PR is included in version 37.369.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I created issue: for us to track this work. |
Changes
sourceUrlSupport/Note
andreleaseTimestampSupport/Note
fields based on the return object of each datasourceContext
Closes: #28947
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: