Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datasource): sourceUrl & releaseTimestamp support #29122

Conversation

RahulGautamSingh
Copy link
Collaborator

Changes

  • Added sourceUrlSupport/Note and releaseTimestampSupport/Note fields based on the return object of each datasource

Context

Closes: #28947

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@RahulGautamSingh RahulGautamSingh changed the title Feat(datasource): sourcelUrl & releaseTimestamp support feat(datasource): sourcelUrl & releaseTimestamp support May 16, 2024
@RahulGautamSingh RahulGautamSingh changed the title feat(datasource): sourcelUrl & releaseTimestamp support feat(datasource): sourceUrl & releaseTimestamp support May 16, 2024
lib/modules/datasource/datasource.ts Outdated Show resolved Hide resolved
lib/modules/datasource/dotnet-version/index.ts Outdated Show resolved Hide resolved
lib/modules/datasource/dotnet-version/index.ts Outdated Show resolved Hide resolved
lib/modules/datasource/unity3d/index.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some common things to fix:

  • Capitalizating abbreviations
  • Grammar

Please check if my suggestions are good/bad before applying them.

Please also check the files I haven't commented on, I ran out of time. 😄

lib/modules/datasource/azure-bicep-resource/index.ts Outdated Show resolved Hide resolved
lib/modules/datasource/bitbucket-tags/index.ts Outdated Show resolved Hide resolved
lib/modules/datasource/cdnjs/index.ts Outdated Show resolved Hide resolved
lib/modules/datasource/conan/index.ts Outdated Show resolved Hide resolved
lib/modules/datasource/conda/index.ts Outdated Show resolved Hide resolved
lib/modules/datasource/npm/index.ts Outdated Show resolved Hide resolved
lib/modules/datasource/nuget/index.ts Outdated Show resolved Hide resolved
lib/modules/datasource/nuget/index.ts Outdated Show resolved Hide resolved
lib/modules/datasource/nuget/index.ts Outdated Show resolved Hide resolved
lib/modules/datasource/nuget/index.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add this to our docs in this PR or a separate one?

@RahulGautamSingh
Copy link
Collaborator Author

Separate would be better, as that will be a doc thing so the scope will change.

@rarkins rarkins added this pull request to the merge queue May 21, 2024
@rarkins
Copy link
Collaborator

rarkins commented May 21, 2024

@RahulGautamSingh please create a follow up Issue then for integrating this with the docs

Merged via the queue into renovatebot:main with commit d0b77e5 May 21, 2024
37 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.369.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@HonkingGoose
Copy link
Collaborator

@RahulGautamSingh please create a follow up Issue then for integrating this with the docs

I created issue:

for us to track this work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document sourceUrl and releaseTimestamp support in datasources
7 participants