-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StreamEntry support Binary #3803
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We must not break the existing implementations.
Hi, @sazzad16, thanks for the review 🙇 |
By creating new methods. I just realized what your title says:
Actually we want StreamEntry binary support while keeping the String ones. |
Thanks, I will update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sazzad16, as I understand, there is xadd support Map<byte[], byte[]> hash
already.
public final CommandObject<byte[]> xadd(byte[] key, XAddParams params, Map<byte[], byte[]> hash) {
return new CommandObject<>(addFlatMapArgs(commandArguments(XADD).key(key).addParams(params), hash),
BuilderFactory.BINARY);
}
@thachlp StreamEntry has nothing to do with XADD. |
Revert Add StreamEntryBinary
1ffa1d7
to
431f721
Compare
Issue: #3566