[PARTMGR] Implement IOCTL_VOLUME_QUERY_VOLUME_NUMBER and IOCTL_VOLUME_IS_PARTITION #6911
+40
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HBelusca
added
enhancement
HBelusca
requested review from
tkreuzer,
binarymaster,
learn-more,
Extravert-ir,
cbialorucki,
ThFabba,
DarkFire01 and
whindsaks
HBelusca
added a commit
to HBelusca/reactos
that referenced
this pull request
May 19, 2024
…_IS_PARTITION (reactos#6911) - Implement IOCTL_VOLUME_QUERY_VOLUME_NUMBER: See usage example in: https://github.com/dansdrivers/ndas4windows/blob/7241cebfa2a2076de546b8841c2ccda8ca599a8d/mayfield/branches/spr/src/umapps/ndassvc/service/drivematch.cpp#L627 - Stubplement IOCTL_VOLUME_IS_PARTITION: The only type of volume we support right now is disk partition so we just return success. A more robust algorithm would be to check whether the volume has only one single extent, that covers the whole partition on which it lies upon. If this is not the case, return STATUS_UNSUCCESSFUL instead.
HBelusca
force-pushed
the
partmgr_simple_volmgr_ioctls
branch
from
3c5a6bc
to
6a36456
Compare
binarymaster
approved these changes
May 19, 2024
DarkFire01
approved these changes
May 19, 2024
HBelusca
commented
May 20, 2024
cbialorucki
approved these changes
May 21, 2024
…_IS_PARTITION (reactos#6911) - Implement IOCTL_VOLUME_QUERY_VOLUME_NUMBER: See usage example in: https://github.com/dansdrivers/ndas4windows/blob/7241cebfa2a2076de546b8841c2ccda8ca599a8d/mayfield/branches/spr/src/umapps/ndassvc/service/drivematch.cpp#L627 - Stubplement IOCTL_VOLUME_IS_PARTITION: The only type of volume we support right now is disk partition so we just return success. A more robust algorithm would be to check whether the volume has only one single extent, that covers the whole partition on which it lies upon. If this is not the case, return STATUS_UNSUCCESSFUL instead.
HBelusca
force-pushed
the
partmgr_simple_volmgr_ioctls
branch
from
6a36456
to
0a8b421
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Used by some 3rd-party software (see example link below). Also,
IOCTL_VOLUME_IS_PARTITIONis an easy way to know whether a\Device\HarddiskVolumeN(or whatever other volume) device corresponds to one single disk partition.Proposed changes
Implement
IOCTL_VOLUME_QUERY_VOLUME_NUMBER: See usage example in: https://github.com/dansdrivers/ndas4windows/blob/7241cebfa2a2076de546b8841c2ccda8ca599a8d/mayfield/branches/spr/src/umapps/ndassvc/service/drivematch.cpp#L627Stubplement
IOCTL_VOLUME_IS_PARTITION: The only type of volume we support right now is disk partition so we just return success. A more robust algorithm would be to check whether the volume has only one single extent, that covers the whole partition on which it lies upon. If this is not the case, return STATUS_UNSUCCESSFUL instead.