-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cluster launcher] [Azure] add option for eviction policy in azure VM template #45397
Merged
rickyyx
merged 1 commit into
ray-project:master
from
ambi-robotics:brijen/delete-template
Jun 3, 2024
Merged
[Cluster launcher] [Azure] add option for eviction policy in azure VM template #45397
rickyyx
merged 1 commit into
ray-project:master
from
ambi-robotics:brijen/delete-template
Jun 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bthananjeyan
requested review from
ericl,
architkulkarni,
hongchaodeng and
a team
as code owners
May 17, 2024 00:26
bthananjeyan
force-pushed
the
brijen/delete-template
branch
from
May 20, 2024 18:47
7b8d4e3
to
312f792
Compare
@architkulkarni @ericl @hongchaodeng please let me know if you have any feedback on this PR, or if there is someone else who should be assigned to review it. Thanks! |
bthananjeyan
force-pushed
the
brijen/delete-template
branch
3 times, most recently
from
May 28, 2024 18:55
3967ace
to
729bdca
Compare
anyscalesam
added
triage
Needs triage (eg: priority, bug/not-bug, and owning component)
core
Issues that should be addressed in Ray Core
labels
May 29, 2024
Signed-off-by: bthananjeyan <brijen@ambirobotics.com>
bthananjeyan
force-pushed
the
brijen/delete-template
branch
from
May 31, 2024 17:13
729bdca
to
0d8fc30
Compare
@architkulkarni @ericl @hongchaodeng bumping this PR in case it was buried. Please let me know if you have any feedback, or if someone else can be assigned to it. I don't have the ability to assign reviewers. |
hongchaodeng
approved these changes
Jun 3, 2024
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 6, 2024
… template (ray-project#45397) <!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. --> ## Why are these changes needed? This is necessary to give users the option to pick an eviction policy (Delete vs Deallocate) when nodes in the cluster are pre-empted. <!-- Please give a short summary of the change and the problem this solves. --> This exposes an additional option that can be set in the `node_config` attribute in the cluster YAML file. ## Related issue number <!-- For example: "Closes ray-project#1234" --> ## Checks - [x] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [x] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [x] This PR is not tested :( --- - To see the specific tasks where the Asana app for GitHub is being used, see below: - https://app.asana.com/0/0/1207339070862431 Signed-off-by: bthananjeyan <brijen@ambirobotics.com> Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 6, 2024
… template (ray-project#45397) <!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. --> ## Why are these changes needed? This is necessary to give users the option to pick an eviction policy (Delete vs Deallocate) when nodes in the cluster are pre-empted. <!-- Please give a short summary of the change and the problem this solves. --> This exposes an additional option that can be set in the `node_config` attribute in the cluster YAML file. ## Related issue number <!-- For example: "Closes ray-project#1234" --> ## Checks - [x] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [x] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [x] This PR is not tested :( --- - To see the specific tasks where the Asana app for GitHub is being used, see below: - https://app.asana.com/0/0/1207339070862431 Signed-off-by: bthananjeyan <brijen@ambirobotics.com> Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
richardsliu
pushed a commit
to richardsliu/ray
that referenced
this pull request
Jun 12, 2024
… template (ray-project#45397) <!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. --> ## Why are these changes needed? This is necessary to give users the option to pick an eviction policy (Delete vs Deallocate) when nodes in the cluster are pre-empted. <!-- Please give a short summary of the change and the problem this solves. --> This exposes an additional option that can be set in the `node_config` attribute in the cluster YAML file. ## Related issue number <!-- For example: "Closes ray-project#1234" --> ## Checks - [x] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [x] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [x] This PR is not tested :( --- - To see the specific tasks where the Asana app for GitHub is being used, see below: - https://app.asana.com/0/0/1207339070862431 Signed-off-by: bthananjeyan <brijen@ambirobotics.com> Signed-off-by: Richard Liu <ricliu@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This is necessary to give users the option to pick an eviction policy (Delete vs Deallocate) when nodes in the cluster are pre-empted.
This exposes an additional option that can be set in the
node_config
attribute in the cluster YAML file.Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.