Add templates from hidden directories #51863
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
The
.devcontainer/*
template files (introduced in #50914 ) were not included in therailties
gem, resulting in a failure to create a new project (rails new foo
).The error was
Could not find ".devcontainer/devcontainer.json" in any of your source paths.
Detail
The
.devcontainer/*
template files were not included in therailties
gem, because the old file pattern didn't match files in hidden directories, only hidden files.Additional information
The issue was observed with
ruby 3.3.0 (2023-12-25 revision 5124f9ac75) [x86_64-linux]
Gem contents for
devcontainer
before the change:Gem contents after the change:
File diff between the two:
Alternative pattern
An alternative could be
but I think it is harder to read.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]