-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add app.rb and helpers.rb back for backward compatibility #51839
Add app.rb and helpers.rb back for backward compatibility #51839
Conversation
e0908c9
to
05702f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to point this to 7-2-stable now that it's been created, so we keep the files there (where console methods are deprecated) but remove from main (where that's likely to be removed anyway)... wdyt?
05702f2
to
0e216e0
Compare
@carlosantoniodasilva 👍 updated |
@@ -0,0 +1,3 @@ | |||
# frozen_string_literal: true | |||
|
|||
require "rails/console/methods" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also add a deprecation warning here so there's a notice before removal in 8.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, let's add a deprecation to the individual files as well, otherwise someone importing it might not realize the files themselves are also going away.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually committed it last week but somehow lost it when switching branches 😅
All updated now. PR description has an example message.
Please merge it on main too 🙏 The issue currently occurs when running Edge Rails. So if this is not fixed on main, then when the next Rails release goes out, it will still be a breaking change for downstream gems. |
Let's deprecate and merge on main as well. We will remove the deprecation later. |
0e216e0
to
65f7286
Compare
65f7286
to
e658f7b
Compare
Those files were removed in rails#51760, but gems like `console1984` depend on these files for legacy Rails console command extensions. So keeping files around is required for backward-compatibility.
e658f7b
to
0b18cac
Compare
Add app.rb and helpers.rb back for backward compatibility
Motivation / Background
Those files were removed in #51760, but gems like
console1984
depend on these files for legacy Rails console command extensions. So keeping files around is required for backward-compatibility.Detail
The files were added back and just require
rails/console/methods.rb
instead with messages like:Additional information
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]