Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom mentions implementation #1486

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rafalp
Copy link
Owner

@rafalp rafalp commented Mar 15, 2023

This PR adds custom mentions implementation in place of jQuery.atWho.

Fixes #1484

TODO

  • Open popup for mention at beginning of post
  • Open popup for first mention in first line
  • Open popup for second mention in first line
  • Open popup for first mention in nth line
  • Open popup for second mention in nth line
  • Close popup on click/touch outside of mentions container
  • Close popup on editor scrooling
  • Respect editor's vertical and horizontal scrolls in top/left calculation
  • Display popup above mention if user to mention is at bottom of editor area
  • Check how superlong words are treated by editor
  • Populate popup with suggestions
  • Fix textarea not being 100% height due to being in container
  • Remove atWho library

Keyboard controls

  • If popup is open, up/down arrows should change active index
  • If popup is open, ender should replace mention under caret with new one
  • If popup is open, esc should close it

@rafalp rafalp added the area: frontend This issue involves JavaScript, React.js and Node label Mar 15, 2023
@rafalp rafalp added this to the Misago 0.30 milestone Mar 15, 2023
@rafalp rafalp self-assigned this Mar 15, 2023
@rafalp
Copy link
Owner Author

rafalp commented Mar 15, 2023

This is not a blocker for 0.30 release. If I fail to finish it, I will release 0.30 without custom mentions and delay this change for next feature release.

@rafalp
Copy link
Owner Author

rafalp commented Mar 16, 2023

Proof of concept work:

misago-mentions.mp4

@rafalp rafalp modified the milestones: Misago 0.32, Misago 1.0 Mar 27, 2023
@rafalp rafalp removed this from the Misago 1.0 milestone May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: frontend This issue involves JavaScript, React.js and Node
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace jQuery atWho with custom mention component
1 participant