Fix shuffle by grouping #4335
Draft
Fix shuffle by grouping #4335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Main reason is to fix how next grouping is changed if going back'n'forth between previous and next grouping. If we have groupings A, B and C, previous way, after playing A and going to B, if previous is used to go to last track of A, next could randomly be B or C, but I would expect it to always get back to B.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check-list
mainWhat this change is adding / fixing
This PR is caused by unexpected behaviour when going back'n'forth between groupings. Fox example if there are albums A, B and C (and grouping is done by album), if complete album A plays out and shuffle selects album B, and I press previous and last track of A starts playing, but next track afterwards will be randomly B or C, while I would still expect it to be B.