Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add releasedate tag #4298

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add releasedate tag #4298

wants to merge 5 commits into from

Conversation

certuna
Copy link

@certuna certuna commented Apr 22, 2023

What this change is adding / fixing

Small change: missing TDRL frame (releasedate) in the id3v2.4 tag mapping. See also: https://github.com/quodlibet/mutagen/blob/2115107ee5d4a1480ecb139723f88ee3b84ed521/mutagen/id3/_frames.py#L690

@declension
Copy link
Member

Thanks. Could you add a couple of unit tests for this please?

@certuna
Copy link
Author

certuna commented Jun 7, 2023

Will check - I actually noticed that the releasedate mapping also seems to be missing in some bits of mutagen (in easyid3.py for example) so I'll have to change it there too.

@declension declension changed the title Update _id3.py Add releasedate tag Oct 22, 2023
@declension
Copy link
Member

declension commented Nov 12, 2023

Hi. Any progress on this PR?

@certuna
Copy link
Author

certuna commented Dec 4, 2023

ah yes apologies, I'll add the tests - this patch is now unmergable due to recent changes so let me work on this a bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants