Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Global undo #4058

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Draft: Global undo #4058

wants to merge 5 commits into from

Conversation

declension
Copy link
Member

@declension declension commented Jul 26, 2022

Add a global undo & use in playlist browser

  • Define undo as a callable with params and an ID, seems neatest
  • Add an ordered undo store
  • Integrate with quodlibet.app
  • Use this to remove delete playlist confirmations via Ctrl-Z (fake) accel. Seems to work nicely!
  • Also fix a playlist deletion bug?

TODOS

  • Add integration test with playlist deletion
  • extract / confirm deletion bug on default
  • Integrate with all other playlist confirm things
  • Add human-readable description for undo action
  • Some kind of TaskController integration? Or native notification?
  • Better exposing of keyboard accels.
  • Put in a menu somewhere too?
  • Docs

Fixes #4063

 * Define undo as a callable with params, seems neatest
 * Add an ordered undo store
 * Add a global instance for this (badly)
   TODO: better integration with app
 * Use this to remove delete playlist confirmations. Seems to work nicely!
 * Also fix a playlist deletion bug?
@declension declension added this to the 4.7 milestone Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add global undo for browser changes etc
1 participant