-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): use correct list type for QSliderSlots (fix: #17060) #17061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
yusufkandemir
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing! I also removed the type itself as it's not needed anymore.
Build ResultsJSON API📜 Changes detected: diff --git a/./current-build/api/QRange.json b/./pr-build/api/QRange.json
index ff50db4..5067ca5 100644
--- a/./current-build/api/QRange.json
+++ b/./pr-build/api/QRange.json
@@ -556,7 +556,7 @@
},
"markerList": {
"type": "Array",
- "tsType": "SliderMarkerLabelArrayConfig",
+ "tsType": "SliderMarkerLabelConfig",
"desc": "Array of marker label configs",
"definition": {
"index": {
@@ -655,7 +655,7 @@
"scope": {
"markerList": {
"type": "Array",
- "tsType": "SliderMarkerLabelArrayConfig",
+ "tsType": "SliderMarkerLabelConfig",
"desc": "Array of marker label configs",
"definition": {
"index": {
diff --git a/./current-build/api/QSlider.json b/./pr-build/api/QSlider.json
index 54302d0..b8530e1 100644
--- a/./current-build/api/QSlider.json
+++ b/./pr-build/api/QSlider.json
@@ -451,7 +451,7 @@
},
"markerList": {
"type": "Array",
- "tsType": "SliderMarkerLabelArrayConfig",
+ "tsType": "SliderMarkerLabelConfig",
"desc": "Array of marker label configs",
"definition": {
"index": {
@@ -550,7 +550,7 @@
"scope": {
"markerList": {
"type": "Array",
- "tsType": "SliderMarkerLabelArrayConfig",
+ "tsType": "SliderMarkerLabelConfig",
"desc": "Array of marker label configs",
"definition": {
"index": { Types📜 Changes detected: diff --git a/./current-build/types/api/slider.d.ts b/./pr-build/types/api/slider.d.ts
index be31a06..0c1c530 100644
--- a/./current-build/types/api/slider.d.ts
+++ b/./pr-build/types/api/slider.d.ts
@@ -40,8 +40,6 @@ export type SliderMarkerLabelConfig = {
style: VueStyleObjectProp;
};
-export type SliderMarkerLabelArrayConfig = SliderMarkerLabelConfig[];
-
export interface SliderMarkerLabelObjectConfig {
[value: number]: SliderMarkerLabelConfig;
}
diff --git a/./current-build/types/index.d.ts b/./pr-build/types/index.d.ts
index a084b57..89bd1ab 100644
--- a/./current-build/types/index.d.ts
+++ b/./pr-build/types/index.d.ts
@@ -10078,7 +10078,7 @@ export interface QRangeSlots {
/**
* Array of marker label configs
*/
- markerList: SliderMarkerLabelArrayConfig[];
+ markerList: SliderMarkerLabelConfig[];
/**
* Object with key-value where key is the model and the value is the marker label config
*/
@@ -10102,7 +10102,7 @@ export interface QRangeSlots {
/**
* Array of marker label configs
*/
- markerList: SliderMarkerLabelArrayConfig[];
+ markerList: SliderMarkerLabelConfig[];
/**
* Object with key-value where key is the model and the value is the marker label config
*/
@@ -11764,7 +11764,7 @@ export interface QSliderSlots {
/**
* Array of marker label configs
*/
- markerList: SliderMarkerLabelArrayConfig[];
+ markerList: SliderMarkerLabelConfig[];
/**
* Object with key-value where key is the model and the value is the marker label config
*/
@@ -11788,7 +11788,7 @@ export interface QSliderSlots {
/**
* Array of marker label configs
*/
- markerList: SliderMarkerLabelArrayConfig[];
+ markerList: SliderMarkerLabelConfig[];
/**
* Object with key-value where key is the model and the value is the marker label config
*/
@@ -16504,7 +16504,6 @@ import { QInputNativeElement } from "./api";
import { QPopupProxyInnerComponent } from "./api";
import { SliderMarkerLabels } from "./api";
import { SliderMarkerLabelConfig } from "./api";
-import { SliderMarkerLabelArrayConfig } from "./api";
import { SliderMarkerLabelObjectConfig } from "./api";
import { QTreeNode } from "./api";
import { QUploaderFactoryFn } from "./api"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
The PR fulfills these requirements:
dev
branch (orv[X]
branch)fix: #xxx[,#xxx]
, where "xxx" is the issue number)This fixes #17060