Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use assert_scalar to emit value range checks #126682

Open
wants to merge 1 commit into
base: gh/ezyang/2782/base
Choose a base branch
from

Conversation

ezyang
Copy link
Contributor

@ezyang ezyang commented May 20, 2024

Stack from ghstack (oldest at bottom):

As we now have range refinement on relational bounds, this reduces the
target operator set.

Signed-off-by: Edward Z. Yang ezyang@meta.com

[ghstack-poisoned]
Copy link

pytorch-bot bot commented May 20, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126682

Note: Links to docs will display an error until the docs builds have been completed.

❌ 21 New Failures, 2 Unrelated Failures

As of commit 6ef7b68 with merge base 2f53747 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: fx release notes category label May 20, 2024
ezyang added a commit that referenced this pull request May 20, 2024
As we now have range refinement on relational bounds, this reduces the
target operator set.

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

ghstack-source-id: 88fbd68171b45215c6875724a4201f38b421b39c
Pull Request resolved: #126682
@albanD albanD removed their request for review May 20, 2024 14:53
@ezyang
Copy link
Contributor Author

ezyang commented May 21, 2024

welp, I guess export doesn't like it. cc @avikchaudhuri @pianpwk @tugsbayasgalan @angelayi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: fx release notes category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants