typing scheduler.py [2/2]: Apply types #126656

aorenste · 2024-05-19T22:22:42Z

Add # mypy: disallow-untyped-defs to scheduler.py and then fix the resulting fallout.

We probably should eventually add a new node between BaseSchedulerNode and all the non-FusedSchedulerNode types to indicate the split between nodes that have a valid self.node and ones that don't. That would cause a lot of the assert self.node is not None churn to go away - but was a bigger change because a lot of code makes assumptions about types that aren't reflected in the types themselves.

Stack from ghstack (oldest at bottom):

-> typing scheduler.py [2/2]: Apply types #126656

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang

[ghstack-poisoned]

pytorch-bot · 2024-05-19T22:22:45Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126656

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❗ 2 Active SEVs

There are 2 currently active SEVs. If your PR is affected, please view them below:

✅ You can merge normally! (2 Unrelated Failures)

As of commit ee738ba with merge base b40fb2d ():

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

inductor / cuda12.1-py3.10-gcc9-sm86 / test (aot_inductor_torchbench, 1, 2, linux.g5.4xlarge.nvidia.gpu, unstable) (gh) ()
No space left on device : '/home/ec2-user/actions-runner/_diag/Worker_20240522-001439-utc.log'
inductor / cuda12.1-py3.10-gcc9-sm86 / test (inductor, 1, 1, linux.g5.4xlarge.nvidia.gpu, unstable) (gh) ()
No space left on device : '/home/ec2-user/actions-runner/_diag/Worker_20240522-001438-utc.log'

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ghstack-source-id: 702b23008da8a43908264dac95bb304970f75dfa Pull Request resolved: #126656

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]

ghstack-source-id: 6596532ae6347becffe4d254bc8dd4e20ef1ed02 Pull Request resolved: #126656

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]

ghstack-source-id: fa31920533cdf7319182e5ef9919054d34d9e545 Pull Request resolved: #126656

eellison

nice, looks good! could you rebase onto more stable master to land ?

torch/_inductor/codegen/triton_foreach.py

Add `# mypy: disallow-untyped-defs` to scheduler.py and then fix the resulting fallout. We probably should eventually add a new node between BaseSchedulerNode and all the non-FusedSchedulerNode types to indicate the split between nodes that have a valid `self.node` and ones that don't. That would cause a lot of the `assert self.node is not None` churn to go away - but was a bigger change because a lot of code makes assumptions about types that aren't reflected in the types themselves. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]

ghstack-source-id: fcd833d9bf666e5f1c63edfd890087a4339973d1 Pull Request resolved: #126656

Add `# mypy: disallow-untyped-defs` to scheduler.py and then fix the resulting fallout. We probably should eventually add a new node between BaseSchedulerNode and all the non-FusedSchedulerNode types to indicate the split between nodes that have a valid `self.node` and ones that don't. That would cause a lot of the `assert self.node is not None` churn to go away - but was a bigger change because a lot of code makes assumptions about types that aren't reflected in the types themselves. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]

ghstack-source-id: 471fe132f4a697469b5723f95ae53cc474bd584f Pull Request resolved: #126656

Add `# mypy: disallow-untyped-defs` to scheduler.py and then fix the resulting fallout. We probably should eventually add a new node between BaseSchedulerNode and all the non-FusedSchedulerNode types to indicate the split between nodes that have a valid `self.node` and ones that don't. That would cause a lot of the `assert self.node is not None` churn to go away - but was a bigger change because a lot of code makes assumptions about types that aren't reflected in the types themselves. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]

ghstack-source-id: a551e876c61c7209cbf15bc6141a1a89d2490cb8 Pull Request resolved: #126656

aorenste · 2024-05-22T14:54:06Z

@pytorchbot merge

pytorchmergebot · 2024-05-22T14:56:04Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-05-22T18:42:33Z

Merge failed

Reason: Not merging any PRs at the moment because there is a merge blocking https://github.com/pytorch/pytorch/labels/ci:%20sev issue open at:
#126896

Details for Dev Infra team

Raised by workflow job

aorenste · 2024-05-22T19:29:39Z

@pytorchbot merge

aorenste · 2024-05-22T20:30:50Z

@pytorchbot merge

pytorchmergebot · 2024-05-22T20:32:54Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

shunting314 · 2024-05-23T21:35:43Z

torch/_inductor/scheduler.py

        snodes = (node,) if isinstance(node, SchedulerNode) else node.snodes
        device = snodes[0].get_device()
        backend = node.scheduler.get_backend(device)
+        assert isinstance(backend, TritonScheduling)


This assert fails. Not sure why CI does not catch it.

oh, maybe CI caches it, but this is caught and skipped

I ran into this as well.

Fixed in #127021

[ghstack-poisoned]

ghstack-source-id: eed2209d050847b8360af87f7569587208bac6c7 Pull Request resolved: #127050

Fix failure from fbcode - in the case of a foreach node the fake `group` needs to be hashable. Pull Request resolved: #127050 Approved by: https://github.com/DanilBaibak ghstack dependencies: #126656

Fix failure from fbcode - in the case of a foreach node the fake `group` needs to be hashable. Pull Request resolved: pytorch#127050 Approved by: https://github.com/DanilBaibak ghstack dependencies: pytorch#126656

Fix typing, attempt 2

fe9d08c

[ghstack-poisoned]

aorenste mentioned this pull request May 18, 2024

typing scheduler.py [1/2]: Bug fix #126610

Closed

pytorch-bot bot added ciflow/inductor module: inductor release notes: foreach_frontend release notes category labels May 19, 2024

aorenste added a commit that referenced this pull request May 19, 2024

Fix typing, attempt 2

6212498

ghstack-source-id: 702b23008da8a43908264dac95bb304970f75dfa Pull Request resolved: #126656

Update on "Fix typing, attempt 2"

f96ed5c

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]

aorenste added a commit that referenced this pull request May 20, 2024

Fix typing, attempt 2

c467074

ghstack-source-id: 6596532ae6347becffe4d254bc8dd4e20ef1ed02 Pull Request resolved: #126656

Update on "Fix typing, attempt 2"

d97d195

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]

aorenste added a commit that referenced this pull request May 20, 2024

Fix typing, attempt 2

671e8d1

ghstack-source-id: fa31920533cdf7319182e5ef9919054d34d9e545 Pull Request resolved: #126656

aorenste changed the title ~~Fix typing, attempt 2~~ typing scheduler.py [2/2]: Apply types May 20, 2024

aorenste requested a review from eellison May 20, 2024 17:48

aorenste marked this pull request as ready for review May 20, 2024 17:49

aorenste added the topic: not user facing topic category label May 20, 2024

eellison approved these changes May 21, 2024

View reviewed changes

torch/_inductor/codegen/triton_foreach.py Outdated Show resolved Hide resolved

aorenste added a commit that referenced this pull request May 21, 2024

Fix typing, attempt 2

cc14d5e

ghstack-source-id: fcd833d9bf666e5f1c63edfd890087a4339973d1 Pull Request resolved: #126656

aorenste added a commit that referenced this pull request May 21, 2024

Fix typing, attempt 2

a8282ac

ghstack-source-id: 471fe132f4a697469b5723f95ae53cc474bd584f Pull Request resolved: #126656

aorenste added a commit that referenced this pull request May 21, 2024

Fix typing, attempt 2

f1b467e

ghstack-source-id: a551e876c61c7209cbf15bc6141a1a89d2490cb8 Pull Request resolved: #126656

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 22, 2024

pytorchmergebot added the merging label May 22, 2024

pytorchmergebot removed the merging label May 22, 2024

pytorchmergebot added the merging label May 22, 2024

pytorchmergebot added the Merged label May 22, 2024

pytorchmergebot closed this in e4623de May 22, 2024

pytorchmergebot removed the merging label May 22, 2024

shunting314 reviewed May 23, 2024

View reviewed changes

aorenste added a commit that referenced this pull request May 24, 2024

Fix to #126656

90a9448

[ghstack-poisoned]

aorenste mentioned this pull request May 24, 2024

Fix to #126656 #127050

Closed

aorenste added a commit that referenced this pull request May 24, 2024

Fix to #126656

0e75c6f

ghstack-source-id: eed2209d050847b8360af87f7569587208bac6c7 Pull Request resolved: #127050

This was referenced May 24, 2024

Improve score_fusion_memory() #127060

Closed

Improve fusable_read_and_write() #127061

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

typing scheduler.py [2/2]: Apply types #126656

typing scheduler.py [2/2]: Apply types #126656

aorenste commented May 19, 2024 •

edited

pytorch-bot bot commented May 19, 2024 •

edited

eellison left a comment

aorenste commented May 22, 2024

pytorchmergebot commented May 22, 2024

pytorchmergebot commented May 22, 2024

aorenste commented May 22, 2024

aorenste commented May 22, 2024

pytorchmergebot commented May 22, 2024

shunting314 May 23, 2024

shunting314 May 23, 2024

Chillee May 24, 2024

aorenste May 24, 2024

typing scheduler.py [2/2]: Apply types #126656

typing scheduler.py [2/2]: Apply types #126656

Conversation

aorenste commented May 19, 2024 • edited

pytorch-bot bot commented May 19, 2024 • edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126656

❗ 2 Active SEVs

✅ You can merge normally! (2 Unrelated Failures)

eellison left a comment

Choose a reason for hiding this comment

aorenste commented May 22, 2024

pytorchmergebot commented May 22, 2024

Merge started

pytorchmergebot commented May 22, 2024

Merge failed

aorenste commented May 22, 2024

aorenste commented May 22, 2024

pytorchmergebot commented May 22, 2024

Merge started

shunting314 May 23, 2024

Choose a reason for hiding this comment

shunting314 May 23, 2024

Choose a reason for hiding this comment

Chillee May 24, 2024

Choose a reason for hiding this comment

aorenste May 24, 2024

Choose a reason for hiding this comment

aorenste commented May 19, 2024 •

edited

pytorch-bot bot commented May 19, 2024 •

edited