Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add versions to deprecated warnings #4262

Merged
merged 11 commits into from
May 20, 2024
Merged

Add versions to deprecated warnings #4262

merged 11 commits into from
May 20, 2024

Conversation

harshil21
Copy link
Member

Closes #4261. To be merged after #4243

Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea, I like it :) Left some questions though

f"The argument `{arg}` is deprecated and will only be available via "
"`ChatFullInfo` in the future.",
PTBDeprecationWarning(
"NEXT.VERSION",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as reminder: In cas this doesn't make it into the same release as #4260, this needs updating

telegram/_chatfullinfo.py Outdated Show resolved Hide resolved
telegram/warnings.py Outdated Show resolved Hide resolved
tests/test_bot.py Show resolved Hide resolved
tests/test_bot.py Show resolved Hide resolved
Also remove one redundant line
Base automatically changed from api-7.3-central to master May 20, 2024 13:25
# Conflicts:
#	telegram/_chat.py
#	telegram/_chatbackground.py
#	telegram/_chatfullinfo.py
#	telegram/_poll.py
#	telegram/ext/_defaults.py
#	telegram/ext/_extbot.py
#	tests/test_bot.py
#	tests/test_official/exceptions.py
@Bibo-Joshi Bibo-Joshi merged commit 512a0b7 into master May 20, 2024
22 of 24 checks passed
@Bibo-Joshi Bibo-Joshi deleted the warning-versions branch May 20, 2024 14:12
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add version deprecated information to PTB raised warnings
3 participants