Allow instrumenting OpenAI/Anthropic client classes or modules #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying logfire-docs with
|
| Latest commit: |
76f8c45
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ef37eff9.logfire-docs.pages.dev |
| Branch Preview URL: | https://alex-instrument-llm-class.logfire-docs.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
|
@willbakst might be interested in reviewing too. |
Kludex
approved these changes
May 20, 2024
| """Instruments the provided `client` with `logfire`.""" | ||
| """Instruments the provided `client` (or clients) with `logfire`. | ||
|
|
||
| `client` can be: |
There was a problem hiding this comment.
Suggested change
| `client` can be: | |
| The `client` can be: |
Comment on lines
31
to
33
| - a single client instance, e.g. an instance of `openai.OpenAI`. | ||
| - a class of a client | ||
| - an iterable of clients/classes. |
There was a problem hiding this comment.
Suggested change
| - a single client instance, e.g. an instance of `openai.OpenAI`. | |
| - a class of a client | |
| - an iterable of clients/classes. | |
| - a single client instance, e.g. an instance of `openai.OpenAI`; | |
| - a class of a client; | |
| - an iterable of clients/classes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a user who wanted to just
logfire.instrument_openai()without passing a client, since they want to instrument langchain which doesn't expose/accept an openai client object: https://pydanticlogfire.slack.com/archives/C06EDRBSAH3/p1715977569378699