Vendor Version logic from packaging #183
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying logfire-docs with 聽
|
| Latest commit: |
ea181d0
|
| Status: | 馃毇聽 Build failed. |
Codecov ReportAttention: Patch coverage is
馃摙 Thoughts on this report? Let us know! |
|
I don't feel good about this. If we don't want to rely on other packages for version parsing then I'd rather find a different solution. For example: version = '2.5.3'
parts = tuple(map(int, version.split('.')[:2]))
print(parts < (2, 6))
print(parts < (2, 5))Parsing a full version requires accounting for betas and stuff (which might be easy enough for known packages like pydantic) but in this case we don't even need the full version, just the first two parts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.