Implement default provider SDK support for Python and NodeJS #16219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2024-05-20)Features
|
tgummerer
force-pushed
the
tg/default-providers-take-2-python-nodejs
branch
from
61f5d76
to
70cf8ea
Compare
tgummerer
force-pushed
the
tg/default-providers-take-2
branch
3 times, most recently
from
34a2eb6
to
253f359
Compare
tgummerer
force-pushed
the
tg/default-providers-take-2-python-nodejs
branch
2 times, most recently
from
54b1e34
to
a67ac5c
Compare
…ne and Go This PR takes an alternative approach for implementing programmatic default providers, that was suggested in the internal design doc. Instead of making the default provider global, we create an API with a callback that creates a new subcontext. In that subcontext and only in that subcontext is the provider set as the default provider. We achieve this by setting up a new monitor with a different port, so the engine can distinguish between the contexts.
tgummerer
force-pushed
the
tg/default-providers-take-2
branch
from
253f359
to
c9e47e4
Compare
tgummerer
force-pushed
the
tg/default-providers-take-2-python-nodejs
branch
from
a67ac5c
to
7253e3e
Compare
tgummerer
force-pushed
the
tg/default-providers-take-2
branch
4 times, most recently
from
5b7821c
to
f20b7ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement SDK support for default providers in Python and NodeJS (this is for the callback based version of default providers). Based on top of #16204 to hopefully make it easier to review the individual parts.
This also includes conformance tests, which I didn't include in the original PR since we don't have conformance testing for Go yet.
Fixes #16167
Fixes #16166