Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(parser): add --subservices tag #3981

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

pedrooot
Copy link
Member

Context

Prowler allows to execute checks from a specific service using --service / --services tag

Description

This pr adds the --subservice / --subservices tag in Prowler. This feature allows you to run checks for a specific subservice(s)

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pedrooot pedrooot requested review from a team as code owners May 13, 2024 12:33
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label May 13, 2024
@sergargar
Copy link
Member

Good job @pedrooot ! But we will have to check all the subservices within the check's metadata. For example, in Kubernetes there are no subservices.

@sergargar
Copy link
Member

And we need to differentiate the service for each subservice.

@github-actions github-actions bot added provider/azure Issues/PRs related with the Azure provider provider/gcp Issues/PRs related with the Google Cloud Platform provider provider/kubernetes Issues/PRs related with the Kubernetes provider github_actions Pull requests that update GitHub Actions code labels May 16, 2024
Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 34.78261% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 86.51%. Comparing base (45ccd7e) to head (17c341e).
Report is 77 commits behind head on master.

Files Patch % Lines
prowler/lib/check/check.py 34.21% 25 Missing ⚠️
prowler/__main__.py 0.00% 4 Missing ⚠️
prowler/lib/check/checks_loader.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3981      +/-   ##
==========================================
- Coverage   86.51%   86.51%   -0.01%     
==========================================
  Files         768      777       +9     
  Lines       23899    24185     +286     
==========================================
+ Hits        20677    20924     +247     
- Misses       3222     3261      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jfagoagas
Copy link
Member

jfagoagas commented May 17, 2024

Are we going to allow the use of --service and --subservice in the same execution? I think it's important just to check an specific subservice instead of all.

@jfagoagas jfagoagas added the no-merge Please, DO NOT MERGE this PR. label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code no-merge Please, DO NOT MERGE this PR. provider/aws Issues/PRs related with the AWS provider provider/azure Issues/PRs related with the Azure provider provider/gcp Issues/PRs related with the Google Cloud Platform provider provider/kubernetes Issues/PRs related with the Kubernetes provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants