New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(client): try CJS-friendly alternative to https://github.com/prisma/prisma/pull/23754 #24029
base: main
Are you sure you want to change the base?
Conversation
size-limit report 📦
|
CodSpeed Performance ReportMerging #24029 will not alter performanceComparing Summary
|
Note, currently 2 tests are failing:
|
I'm not sure if this is the cause of the error, but it probably requires a fix in the import destination. In this file, I think it needs to dynamically import the loader first and then dynamically import the engine. prisma/packages/client/src/generation/utils/buildGetQueryEngineWasmModule.ts Lines 31 to 33 in 02deb42
|
This PR is an alternative version of #23754, specifically aimed to guarantee that Prisma Client keeps working when distributed as a CommonJS package.
This PR addresses this failing e2e test, aiming to avoid the esbuild error: