Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made OutputMatcher take Collection #22786

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wonderfulvamsi
Copy link

@wonderfulvamsi wonderfulvamsi commented May 19, 2024

Description

OutputMatcher is being used in a method called withOutput in PlanMatchPattern class.
So i made the code changes in those files to take Collection instead of a List.

Motivation and Context

Order is not important in OutputMatcher class so this is semantically correct, and in some cases it would have been mildly more convenient to pass in a Set instead of a List.

fixes #22756

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* ... :pr:`12345`
* ... :pr:`12345`

Hive Connector Changes
* ... :pr:`12345`
* ... :pr:`12345`

If release note is NOT required, use:

== NO RELEASE NOTE ==

Copy link

linux-foundation-easycla bot commented May 19, 2024

CLA Not Signed

  • ❌ login: @VamZ / The commit (986637e). This user is authorized, but they must confirm their affiliation with their company. Start the authorization process by clicking here, click "Corporate", select the appropriate company from the list, then confirm your affiliation on the page that appears. For further assistance with EasyCLA, please submit a support request ticket.

@wonderfulvamsi wonderfulvamsi marked this pull request as draft May 20, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OutputMatcher should take a Collection rather than a List
2 participants