Bug-fix: spo tenant recyclebinitem restore
#6057
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milanholemans
requested changes
May 17, 2024
src/m365/spo/commands/tenant/tenant-recyclebinitem-restore.spec.ts
Outdated
Show resolved
Hide resolved
src/m365/spo/commands/tenant/tenant-recyclebinitem-restore.spec.ts
Outdated
Show resolved
Hide resolved
src/m365/spo/commands/tenant/tenant-recyclebinitem-restore.spec.ts
Outdated
Show resolved
Hide resolved
milanholemans
approved these changes
May 18, 2024
| } | ||
|
|
||
| await logger.log(responseContent); | ||
| // Here, we return a fixed response due to removing the '--wait' functionality as it is deprecated. |
There was a problem hiding this comment.
In fact, we are not doing this because we are removing --wait, but because we switched to a new endpoint that has no output.
| })) { | ||
| return "{\"HasTimedout\":false,\"IsComplete\":true,\"PollingInterval\":15000}"; | ||
| } | ||
| it(`restores deleted group site from a deleted team site`, async () => { |
There was a problem hiding this comment.
Suggested change
| it(`restores deleted group site from a deleted team site`, async () => { | |
| it(`restores deleted group from a deleted team site`, async () => { |
| assert.strictEqual(postStub.lastCall.args[0].url, groupRestoreUrl); | ||
| }); | ||
|
|
||
| it('restores restores a deleted SharePoint site', async () => { |
There was a problem hiding this comment.
Suggested change
| it('restores restores a deleted SharePoint site', async () => { | |
| it('restores a deleted SharePoint site without group', async () => { |
|
Merged manually, thank you for this fix! 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6021