Enhances entra user list properties
#6056
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milanholemans
requested changes
May 20, 2024
milanholemans
requested changes
May 22, 2024
milanholemans
approved these changes
May 23, 2024
| if (options.type) { | ||
| filter += filter.length > 0 ? ` and userType eq '${options.type}'` : `$filter=userType eq '${options.type}'`; | ||
| if (type) { | ||
| filter += filter.length > 0 ? ` and userType eq '${type}'` : `$filter=userType eq '${type}'`; |
There was a problem hiding this comment.
Now we're checking twice if there are any filters. I think it's a lot clearer if we throw all filters in a single array and use that array as a filter string.
| catch (ex: any) { | ||
| throw ex; | ||
|
|
||
| const unknownOptions: Options = this.getUnknownOptions(args.options); |
There was a problem hiding this comment.
In fact, we cannot type this as Options. All properties declared in this interface will never be part of this object.
|
Merged manually, thank you for this addition! 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4667
I have also noticed that we added the option
typewith an autocomplete in a previous PR, but we didn't validate the options being passed, resulting in the command throwing an error when we used a user type other thanmemberorguest.