Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ticket/17151] Make settings forms use macros #6533

Merged
merged 17 commits into from
Jun 4, 2024
Merged

[ticket/17151] Make settings forms use macros #6533

merged 17 commits into from
Jun 4, 2024

Conversation

rxu
Copy link
Contributor

@rxu rxu commented Sep 18, 2023 •
edited

PHPBB3-17151

Checklist:

  • Correct branch: master for new features; 3.3.x for fixes
  • Tests pass
  • Code follows coding guidelines: master and 3.3.x
  • Commit follows commit message format

Tracker ticket:

https://tracker.phpbb.com/browse/PHPBB3-17151

@rxu rxu force-pushed the ticket/17151-2 branch 7 times, most recently from 96dfeca to 10cd704 Compare September 20, 2023 13:21
@rxu rxu marked this pull request as ready for review September 21, 2023 08:03
Derky
Derky requested changes Sep 22, 2023
View reviewed changes
phpBB/includes/functions_acp.php Show resolved Hide resolved
phpBB/styles/all/template/macros/forms/select.twig Show resolved Hide resolved
phpBB/styles/all/template/macros/forms/select.twig Show resolved Hide resolved
phpBB/styles/all/template/macros/forms/select.twig Show resolved Hide resolved
tests/functional/fixtures/ext/foo/bar/acp/main_module.php Outdated Show resolved Hide resolved
phpBB/includes/functions_acp.php Outdated Show resolved Hide resolved
@rxu rxu marked this pull request as draft September 22, 2023 17:45
@rxu rxu force-pushed the ticket/17151-2 branch 11 times, most recently from ff5a983 to dddd937 Compare September 24, 2023 03:40
@rxu rxu requested a review from Derky September 24, 2023 08:59
@rxu rxu marked this pull request as ready for review September 25, 2023 00:45
@Derky
Copy link
Member

Derky commented Oct 1, 2023

Thanks for updating the PR! I've also asked @marc1706 to take a look at the radio options to see if it's aligned with his recent changes to form elements.

I've been testing this PR around a bit and the board settings page is working again now, but I noticed there are no selected="selected" attributes on both the "Default style" as "Guest style". So this causes the first option in the selectbox to show as selected. (So if you select a different style, it doesn't show that as selected next time you return to the page)

@rxu
Copy link
Contributor Author

rxu commented Oct 2, 2023 •
edited

there are no selected="selected" attributes on both the "Default style" as "Guest style".

At what page?

EDIT: okay, I see the cause. Will be fixed in next commits.

@rxu rxu force-pushed the ticket/17151-2 branch 2 times, most recently from c9fd647 to da04734 Compare October 2, 2023 05:18
@rxu rxu force-pushed the ticket/17151-2 branch 3 times, most recently from 372b5f7 to d4190df Compare October 3, 2023 05:49
@rxu
Copy link
Contributor Author

rxu commented Oct 3, 2023

@marc1706 Done.

@marc1706 marc1706 added this to the 4.0.0-a1 milestone Oct 5, 2023
@rubencm rubencm mentioned this pull request Feb 19, 2024
Open
9 tasks
rxu added 15 commits May 25, 2024 11:57
@rxu
[ticket/17151] Make settings forms use macros
7277093 
PHPBB3-17151
@rxu
[ticket/17151] Fix test error
9350e82 
PHPBB3-17151
@rxu
[ticket/17151] Fix registration test error
52517a5 
PHPBB3-17151
@rxu
[ticket/17151] Fix tests
7b04e41 
PHPBB3-17151
@rxu
[ticket/17151] Deduplicate code for building configuration options data
7f36585 
PHPBB3-17151
@rxu
[ticket/17151] Improve radio input type handling
1cbe1d8 
- allow more than 2 buttons count
- allow custom buttons order
- allow custom button labels

Implemented by allowing JSON data format, backward compatibility preserved.

PHPBB3-17151
@rxu
[ticket/17151] Fix PHP warning on board settings page, add ACP pages …
130366e 
…test

PHPBB3-17151
@rxu
[ticket/17151] Adjust template output formatting
830c1f3 
PHPBB3-17151
@rxu
[ticket/17151] Refactor radio buttons output logic
9401a59 
PHPBB3-17151
@rxu
[ticket/17151] Fix avatar ACP options
2d0969e 
PHPBB3-17151
@rxu
[ticket/17151] Reimplement radio buttons yes_no / enabled_disabled sh…
6349d3c 
…orthands

PHPBB3-17151
@rxu
[ticket/17151] Revert radio yes_no/enabled_disabled, fix select "sele…
b657265 
…cted"

PHPBB3-17151
@rxu
[ticket/17151] Extend forms tests
f28d337 
PHPBB3-17151
@rxu
[ticket/17151] Adjust code styling
3597c15 
PHPBB3-17151
@rxu
[ticket/17151] Make textarea id optional
463848d 
PHPBB3-17151
marc1706
marc1706 reviewed May 27, 2024
View reviewed changes
phpBB/includes/functions_acp.php Show resolved Hide resolved
phpBB/includes/functions_acp.php Show resolved Hide resolved
phpBB/includes/functions_acp.php Show resolved Hide resolved
@rxu
[ticket/17151] Add core.build_config_template event @Changed information
03e2222 
The event location's function has been renamed
from build_config_template() to phpbb_build_cfg_template().

PHPBB3-17151
@rxu rxu mentioned this pull request Jun 4, 2024
Merged
@marc1706 marc1706 merged commit 272daae into phpbb:master Jun 4, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Derky Derky Derky requested changes

@rubencm rubencm rubencm left review comments

@marc1706 marc1706 marc1706 approved these changes

Assignees
No one assigned
Labels
4.0 (Triton) 🔮
Projects
None yet
Milestone
4.0.0-a1
4 participants
@rxu @Derky @marc1706 @rubencm