Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ticket/17059] Add emojis to assets and use instead of CDN version #6442

Open
wants to merge 3 commits into
base: 3.3.x
Choose a base branch
from
Open

[ticket/17059] Add emojis to assets and use instead of CDN version #6442

wants to merge 3 commits into from

Conversation

marc1706
Copy link
Member

@marc1706 marc1706 commented Jan 1, 2023 •
edited

Replaces #6427

Checklist:

  • Correct branch: master for new features; 3.3.x for fixes
  • Tests pass
  • Code follows coding guidelines: master and 3.3.x
  • Commit follows commit message format

Tracker ticket (set the ticket ID to your ticket ID):

https://tracker.phpbb.com/browse/PHPBB3-17059

@rubencm
Copy link
Member

rubencm commented Jan 9, 2023

Maybe we can use git submodules for this?
By doing this you have added all their emojis without their license

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
3.3 (Proteus) 🌑 Do not merge ✋ Under discussion ⁉️
Projects
None yet
Milestone
No milestone
2 participants
@marc1706 @rubencm