Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix batch scripts #305

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix batch scripts #305

wants to merge 3 commits into from

Conversation

hansipie
Copy link

->'print_heading' was not found + erratic behaviour

  • replace 'echo' by 'print_heading' in 'create_venv.bat'
  • fix doc: 'create_venv_win.bat' to 'create_venv.bat'

->'print_heading' was not found + erratic behaviour
+ replace 'echo' by 'print_heading' in 'create_venv.bat'
+ fix doc:  'create_venv_win.bat' to 'create_venv.bat'
@jacobweiss2305
Copy link
Contributor

@ashpreetbedi LGTM. Tested and it works.

Copy link
Contributor

@jacobweiss2305 jacobweiss2305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hansipie hansipie mentioned this pull request May 18, 2024
@hansipie
Copy link
Author

hello .... merging is blocked .... is there someting i have to do ?

@jacobweiss2305
Copy link
Contributor

@ashpreetbedi will finish review and merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants