Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiselect relationship bug and improve accessibility #6286

Merged
merged 4 commits into from May 15, 2024

Conversation

JessChowdhury
Copy link
Member

Description

Closes #117 - hitting the space key while the ReactSelect is in focus crashes the page.

This PR makes the following changes:

  • Multivalue select component updated to only use id, drag feature does not work when using uuid()

  • Ensures relationship field (multi and single value) can be accessed via the keyboard

  • I have read and understand the CONTRIBUTING.md document in this repository.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Existing test suite passes locally with my changes

Copy link
Contributor

@JarrodMFlesch JarrodMFlesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple other small things:

  • Lets make the chevron stroke 1px when inside a relationship select to match the other icons
  • I am unable to focus on the EditIcon and open the modal for editing when the relationship is a hasMany

@JessChowdhury
Copy link
Member Author

@JarrodMFlesch pushed the following changes:

  • change the chevron stroke width to 1px
  • show focus outline for EditIcon when the relationship is a hasMany
  • update the dropdown indicator to a button element
  • simplify the drowdown indicator onClick as suggested

@JessChowdhury JessChowdhury enabled auto-merge (squash) May 15, 2024 13:31
@JessChowdhury JessChowdhury merged commit 5a4074e into beta May 15, 2024
35 checks passed
@JessChowdhury JessChowdhury deleted the fix/multi-relationship-field branch May 15, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maximum update depth exceeded when hitting space key while editing a related document
2 participants