New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Facebook Limited Login not working due to incorrect domain in JWT validation #9122
fix: Facebook Limited Login not working due to incorrect domain in JWT validation #9122
Conversation
The branch Pull requests are usually opened against the default branch |
Thanks for opening this pull request! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #9122 +/- ##
==========================================
+ Coverage 94.13% 94.15% +0.01%
==========================================
Files 186 186
Lines 14687 14724 +37
==========================================
+ Hits 13826 13863 +37
Misses 861 861 ☔ View full report in Codecov by Sentry. |
@chriscborg would you please merge alpha or rebase? Unfortunately I can't do it since your PR is protected. |
…fix/release/issue_9117
# [7.1.0-alpha.7](7.1.0-alpha.6...7.1.0-alpha.7) (2024-05-16) ### Bug Fixes * Facebook Limited Login not working due to incorrect domain in JWT validation ([#9122](#9122)) ([9d0bd2b](9d0bd2b))
🎉 This change has been released in version 7.1.0-alpha.7 |
Pull Request
Issue
Add support for Facebook auth JWT token #9117
Closes: #9117
Approach
A JWT token validation implementation seems to be already in place, however the host needs to be changed from facebook.com to www.facebook.com as suggested by @SebC99, because the old host is returning error 301 which is not followed by the jwt-rsa package.
Tasks