Make EINTR less common
#10997
Open
Make EINTR less common
#10997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
reviewed
May 11, 2024
CMakeLists.txt
Outdated
| @@ -1121,6 +1121,10 @@ if(APPLE) | |||
| target_link_options(${bun} PUBLIC "-dead_strip_dylibs") | |||
| target_link_options(${bun} PUBLIC "-Wl,-stack_size,0x1200000") | |||
| target_link_options(${bun} PUBLIC "-exported_symbols_list" "${BUN_SRC}/symbols.txt") | |||
|
|
|||
| # Must be anbled after macOS 14 | |||
There was a problem hiding this comment.
Suggested change
| # Must be anbled after macOS 14 | |
| # Must be enabled after macOS 14 |
paperdave
reviewed
May 13, 2024
| @@ -9,7 +9,7 @@ on: | |||
| inputs: | |||
| runs-on: | |||
| type: string | |||
| default: macos-12-large | |||
| default: macos-13-large | |||
There was a problem hiding this comment.
are we dropping MacOS 12 support?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This makes
EINTRless likely to occur on macOS by ensuring we only use the$NOCANCELversions of symbols where possible. This also should very slightly improve start performance since there are ~20 fewer symbols to loadHow did you verify your code works?
CI