New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix backtick escaping and add more tests #10980
Conversation
Are there any other characters that need to be escaped? How do we avoid this from happening again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but env.positionals.test.ts
is failing
@zackradisic merge conflict sorry |
re-running because hard to tell if flaky or new test failures |
Thank you |
Is there a date for when this merged PR is getting published? |
What does this PR do?
This fixes shell not escaping a string with backticks and no other special characters
Also added more tests for shell escaping