Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backtick escaping and add more tests #10980

Merged
merged 11 commits into from May 14, 2024
Merged

Conversation

zackradisic
Copy link
Contributor

What does this PR do?

This fixes shell not escaping a string with backticks and no other special characters

Also added more tests for shell escaping

@Jarred-Sumner
Copy link
Collaborator

Are there any other characters that need to be escaped? How do we avoid this from happening again?

Copy link

github-actions bot commented May 10, 2024

@zackradisic, your commit has failing tests :(

💪 5 failing tests Darwin AARCH64

💻 3 failing tests Darwin x64 baseline

💻 2 failing tests Darwin x64

🐧🖥 1 failing tests Linux x64

🪟💻 10 failing tests Windows x64 baseline

🪟💻 13 failing tests Windows x64

View logs

Copy link
Contributor

@gvilums gvilums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but env.positionals.test.ts is failing

@Jarred-Sumner
Copy link
Collaborator

@zackradisic merge conflict sorry

@Jarred-Sumner
Copy link
Collaborator

re-running because hard to tell if flaky or new test failures

@Jarred-Sumner Jarred-Sumner merged commit 60482b6 into main May 14, 2024
46 of 52 checks passed
@Jarred-Sumner Jarred-Sumner deleted the zack/shell-escape-backtick branch May 14, 2024 21:23
@Jarred-Sumner
Copy link
Collaborator

Thank you

@BalduinB
Copy link

Is there a date for when this merged PR is getting published?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants