Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework node:net.connect arg parsing #10970

Merged
merged 15 commits into from May 15, 2024
Merged

rework node:net.connect arg parsing #10970

merged 15 commits into from May 15, 2024

Conversation

nektro
Copy link
Contributor

@nektro nektro commented May 10, 2024

Co-authored-by: @henrikstorck
Revival of #10870
Revert of #10908

Closes #10854

Co-authored-by: 13228538+henrikstorck@users.noreply.github.com
Copy link

github-actions bot commented May 10, 2024

@nektro, your commit has failing tests :(

💪 2 failing tests Darwin AARCH64

💻 4 failing tests Darwin x64 baseline

🐧🖥 1 failing tests Linux x64 baseline

🪟💻 11 failing tests Windows x64 baseline

🪟💻 13 failing tests Windows x64

View logs

@nektro nektro marked this pull request as ready for review May 10, 2024 07:40
cwd: package_dir,
stdout: "pipe",
stdin: "ignore",
stderr: "pipe",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
stderr: "pipe",
stderr: "inherit",

We can check the exit code instead and see the error log in CI

Copy link
Contributor Author

@nektro nektro May 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes the logs very noisy and nulls the use of any expect matchers

@nektro nektro marked this pull request as draft May 11, 2024 00:22
@nektro nektro marked this pull request as ready for review May 11, 2024 03:18
@nektro nektro requested a review from Jarred-Sumner May 14, 2024 01:35
src/js/node/http2.ts Outdated Show resolved Hide resolved
@nektro nektro requested a review from Jarred-Sumner May 15, 2024 00:17
@Jarred-Sumner Jarred-Sumner merged commit 1e6fa76 into main May 15, 2024
12 of 20 checks passed
@Jarred-Sumner Jarred-Sumner deleted the nektro-patch-7146 branch May 15, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure Service Bus package not working with Bun
2 participants