New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(fetch) allow Response to be GC'd before all the request body is received #10933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ @cirospaciari, your commit has failing tests :( 💻 2 failing tests Darwin x64 baseline
🪟💻 9 failing tests Windows x64 baseline
🪟💻 14 failing tests Windows x64
|
cirospaciari
changed the title
WIP: fetch lazy promise
fix(fetch) allow Response to be GC'd before all the request body is received
May 13, 2024
cirospaciari
force-pushed
the
ciro/lazy-promise-fetch
branch
from
May 13, 2024 18:11
0326347
to
ea09533
Compare
cirospaciari
force-pushed
the
ciro/lazy-promise-fetch
branch
3 times, most recently
from
May 20, 2024 14:55
7ad1bfb
to
689d90e
Compare
serve test still failing |
cirospaciari
force-pushed
the
ciro/lazy-promise-fetch
branch
from
May 22, 2024 20:31
e12dba0
to
8818997
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
How did you verify your code works?
Added tests