Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fetch) allow Response to be GC'd before all the request body is received #10933

Merged
merged 29 commits into from May 22, 2024

Conversation

cirospaciari
Copy link
Collaborator

@cirospaciari cirospaciari commented May 8, 2024

What does this PR do?

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

Added tests

Copy link

github-actions bot commented May 10, 2024

@cirospaciari, your commit has failing tests :(

💻 2 failing tests Darwin x64 baseline

  • test/bundler/large_asset_regression.test.ts 1 failing
  • test/cli/install/bun-create.test.ts 2 failing

🪟💻 9 failing tests Windows x64 baseline

  • test/cli/install/bunx.test.ts 1 failing
  • test/integration/next-pages/test/dev-server-ssr-100.test.ts 1 failing
  • test/js/bun/shell/bunshell.test.ts 1 failing
  • test/js/bun/shell/commands/rm.test.ts 1 failing
  • test/js/node/child_process/child_process.test.ts 1 failing
  • test/js/node/dns/node-dns.test.js 2 failing
  • test/js/node/process/process.test.js 2 failing
  • test/js/node/watch/fs.watchFile.test.ts SIGKILL
  • test/js/web/workers/worker.test.ts 2 failing

🪟💻 14 failing tests Windows x64

  • test/cli/install/bun-install.test.ts 12 failing
  • test/cli/install/bunx.test.ts SIGKILL
  • test/cli/install/migration/complex-workspace.test.ts 7 failing
  • test/cli/install/migration/migrate.test.ts 1 failing
  • test/cli/install/registry/bun-install-registry.test.ts 2 failing
  • test/integration/esbuild/esbuild.test.ts 1 failing
  • test/js/bun/http/serve-body-leak.test.ts 3 failing
  • test/js/bun/shell/bunshell.test.ts 1 failing
  • test/js/bun/shell/commands/rm.test.ts 1 failing
  • test/js/node/child_process/child_process.test.ts 1 failing
  • test/js/node/dns/node-dns.test.js SIGKILL
  • test/js/node/process/process.test.js 2 failing
  • test/js/node/watch/fs.watchFile.test.ts SIGKILL
  • test/js/web/workers/worker.test.ts 2 failing

View logs

@cirospaciari cirospaciari changed the title WIP: fetch lazy promise fix(fetch) allow Response to be GC'd before all the request body is received May 13, 2024
@cirospaciari cirospaciari marked this pull request as ready for review May 13, 2024 17:19
@cirospaciari cirospaciari force-pushed the ciro/lazy-promise-fetch branch 3 times, most recently from 7ad1bfb to 689d90e Compare May 20, 2024 14:55
@Jarred-Sumner
Copy link
Collaborator

serve test still failing

@Jarred-Sumner Jarred-Sumner merged commit 096cfee into main May 22, 2024
50 of 53 checks passed
@Jarred-Sumner Jarred-Sumner deleted the ciro/lazy-promise-fetch branch May 22, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants