-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX #10274: Create global initial version constant and use it for initializing all the versioned entities #20301
Conversation
Hi @Patrick-Haselof, can you complete the following:
|
Assigning @lkbhitesh07 for the first pass review of this PR. Thanks! |
Hi! @Patrick-Haselof Welcome to Oppia! Could you please follow the instructions here and sign the CLA Sheet to get started? You'll need to do this before we can accept your PR. Thanks! |
This was an accident, I meant to push to my Fork |
Hi @Patrick-Haselof, can you complete the following:
|
Hi! @Patrick-Haselof Welcome to Oppia! Could you please follow the instructions here and sign the CLA Sheet to get started? You'll need to do this before we can accept your PR. Thanks! |
This PR is trying to merge from my Branch instead of my Fork. I tried editing and even creating a new PR, didn't manage to do it, so for now I'll leave this open. |
Hey @Patrick-Haselof, thanks for the changes. I would suggest to follow this comment mentioned on the issue and then make the changes to this PR, this is the pattern we are currently following. |
Hi @Patrick-Haselof, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue. |
I have updated the PR as requested, but sadly I cannot continue to work on this PR given that my assignment requires me to pick another one that involves refactoring. I'm sorry, time really isn't at my side right now. |
Hi @Patrick-Haselof, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue. |
Overview
Modified files:
Found that needed refactoring but needs to be looked into/Uncertain of how to properly modify:
What changed:
This Issue fix is pure refactoring and no logic has been modified or added
Essential Checklist
Please follow the instructions for making a code change.
Proof that changes are correct
This is a simple refactoring work. Since the code logic has not been modified there is no proof.
PR Pointers