Creators and Learners can access voiceovers with accent #20163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r_voice_artists
…r_voice_artists
…r_voice_artists
…r_voice_artists
…voiceovers_with_accent
…r_voice_artists
…r_voice_artists
…voiceovers_with_accent
Nik-09
commented
May 30, 2024
There was a problem hiding this comment.
Hi @vojtechjelinek PTAL once you are free.
Also, @Lawful2002 I have addressed the comment. PTAL
Thank you
Lawful2002
approved these changes
Jun 2, 2024
|
Unassigning @Lawful2002 since they have already approved the PR. |
|
Hi @Nik-09, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks! |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
7 tasks
AFZL210
pushed a commit
to AFZL210/oppia
that referenced
this pull request
Jun 12, 2024
* Adds flag to prevent voiceover contribution * Adds feature flag to add voiceover with accent. * Fixes lint issues * Fixes lint issues * Fixes lint, mypy, prettier, frontend, backend tests * updates variable name * Updates UI * updates variable name * Fixes backend test * Removes platform param variable * Removes redundant code. * Updates flag name. * Fixes frontend tests * Adds helper method to enable voiceover contribution feature flag. * Fixes e2e test * Adds voiceover update helper method * Adds entity voiceover helper methods. * Fixes e2e test * Enabled video recording * Adds get voiceover APIs * Fixes E2E test * Adds voiceover card * Updates UI * Updates feature flag name from snake case to camel case * Updates feature flag for voiceovers * Enabled video recording for debugging e2e. * Adds voiceover removal functionality * Disables video recording for e2e tests * Removes waitfor method * Fixes backend tests * Adds progress bar * Enables videos recording * Fixes exploration editor bug * Updates UI * Add backend API methods * Enables flag for recording voiceovers * Changes logged in username * updates e2e test * Updates e2e test * Updates model * Updates e2e tests * Disable video recording for e2e test * Adds backend code comments. * Adds docstring. * Fixes frontend test * Updates frontend methods * Updates frontend methods * Updates frontend * Adds voiceover from change list * Updates status graph code on voiceover addition * Updates UI * Removes console * Fixes state translation frontend tests * Fixes frontend tests for translator overview. * Fixes frontend test for translation status service * Fixes lint issues * Adds frontend tests * Fixes lint issues * Adds CSS * Updates learner facing UI. * Updates minute variable names and code comments * Adds backend + frontend unit tests * Adds frontend tests * Fixes frontend tests * Fixes lint checks * Fixes mypy checks * removes redundant code * Fixes typescript checks * Updates test case names * Adds backend coverage tests * Adds backend coverage tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The PR introduces the changes so that creators and voiceover artists can now add voiceovers for state content in a specific accent of a language. And learners can access those voiceovers on the exploration player page.
This feature will be hidden behind the feature flag to smoothly launch the functionality.
Essential Checklist
Please follow the instructions for making a code change.
Testing doc (for PRs with Beam jobs that modify production server data)
Proof that changes are correct
Description: The below video demonstrates that voice artists can add manual voiceover using the new UI for the English language in a Canadian accent.
add_voiceover_in_a_language.mp4
Description: The below video demonstrates that voice artists can add manual voiceovers using the new UI for English in a Canadian accent and Hindi language in an Indian accent.
add_voiceover_in_two_different_languages.mp4
Description: The below video demonstrates that learners can access English voiceover in the Canadian language.
learning_in_english.online-video-cutter.com.mp4
Description: The below video demonstrates that learners can access Hindi voiceover in the Indian language.
learning_in_hindi.mp4
Proof of changes on desktop with slow/throttled network
Proof of changes on mobile phone
Proof of changes in Arabic language
PR Pointers