-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Default value for verification flags is 'SSL_VERIFY_NONE' #24435
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ruslo
commented
May 18, 2024
- documentation is added or updated
paulidale
approved these changes
May 19, 2024
paulidale
added
branch: master
Merge to master branch
approval: review pending
This pull request needs review by a committer
labels
May 19, 2024
t8m
requested changes
May 20, 2024
t8m
added
triaged: documentation
The issue/pr deals with documentation (errors)
branch: 3.0
Merge to openssl-3.0 branch
branch: 3.1
Merge to openssl-3.1
tests: exempted
The PR is exempt from requirements for testing
branch: 3.2
Merge to openssl-3.2
branch: 3.3
Merge to openssl-3.3
labels
May 20, 2024
ruslo
force-pushed
the
pr.default_mode_is_none
branch
from
May 20, 2024 14:02
82dc075
to
07432cc
Compare
ruslo
changed the title
[Docs] Default 'mode' is 'SSL_VERIFY_NONE'
[Docs] Default value for verification flags is 'SSL_VERIFY_NONE'
May 20, 2024
t8m
approved these changes
May 20, 2024
@paulidale please reconfirm |
shahsb
approved these changes
May 20, 2024
yes, good |
paulidale
added
approval: done
This pull request has the required number of approvals
and removed
approval: review pending
This pull request needs review by a committer
labels
May 20, 2024
openssl-machine
added
approval: ready to merge
The 24 hour grace period has passed, ready to merge
and removed
approval: done
This pull request has the required number of approvals
labels
May 21, 2024
This pull request is ready to merge |
Merged to all the active branches. Thank you for your contribution. |
openssl-machine
pushed a commit
that referenced
this pull request
May 22, 2024
Reviewed-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #24435)
jvdsn
pushed a commit
to jvdsn/openssl
that referenced
this pull request
Jun 3, 2024
Reviewed-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#24435)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approval: ready to merge
The 24 hour grace period has passed, ready to merge
branch: master
Merge to master branch
branch: 3.0
Merge to openssl-3.0 branch
branch: 3.1
Merge to openssl-3.1
branch: 3.2
Merge to openssl-3.2
branch: 3.3
Merge to openssl-3.3
tests: exempted
The PR is exempt from requirements for testing
triaged: documentation
The issue/pr deals with documentation (errors)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.