Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DO NOT MERGE: PRPQR test for excepted_failures #28809

Closed
wants to merge 20 commits into from
Closed

DO NOT MERGE: PRPQR test for excepted_failures #28809

wants to merge 20 commits into from

Conversation

DennisPeriquet
Copy link
Contributor

/hold

This is just a PR used to try PRPQR method to launch single job.
DO NOT MERGE

@DennisPeriquet
add exception for vsphere due to single replica
cf4261a
@DennisPeriquet
See how many jobs fail with Degraded=True and Available=False
6f2b9ef
@DennisPeriquet
If Available=False outside of upgrade window, we fail
200a800
@DennisPeriquet
Allow transitions during upgrade for cluster-storage-operator for vsp…
d16be54 
…here with 1 replica
@DennisPeriquet
we will work on TRT-1575 separately
6e95796
@DennisPeriquet
handle single replica operators during upgrade window
cba84df
@DennisPeriquet
for cases besides single replica, attempt to match exceptions
b158c9e
@DennisPeriquet
Rearrage since all exceptions refer to Available=False
beeb5d6
@DennisPeriquet
Honor Available=False exceptions only if not in upgrade window
efde445
@DennisPeriquet
make unit tests for the isInUpgradeWindow fix bugs found
89a3143
@DennisPeriquet
refactor to make unit test smaller, readable, extendable
b8aec3c
@DennisPeriquet
gofmt
676bb08
@DennisPeriquet
review comments 1
cc302fd
@DennisPeriquet
inline the testcases with the test
a15769e
@DennisPeriquet
fixup to make more readable
5ff612f
@DennisPeriquet
add Jira for image-registry single replica exception
dcaf8e1
@DennisPeriquet
Revise upgrade window logic to catch all cases; update unit tests
fe7305c
@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 17, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 17, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DennisPeriquet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2024
@DennisPeriquet
Copy link
Contributor Author

/hold

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 31, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@DennisPeriquet
Copy link
Contributor Author

this is no longer needed

@DennisPeriquet DennisPeriquet deleted the prpqr-excepted-failures1 branch May 31, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DennisPeriquet @openshift-merge-robot