Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle BGRA streams in GStreamer backend #25602

Open
wants to merge 1 commit into
base: 4.x
Choose a base branch
from

Conversation

asmorkalov
Copy link
Contributor

@asmorkalov asmorkalov commented May 17, 2024

Safer replacement for #25557
Jetson Orin provides BGRx stream in some cases.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added this to the 4.10.0 milestone May 17, 2024
@asmorkalov asmorkalov changed the title Handle BGRA sterams in GStreamer backend Handle BGRA streams in GStreamer backend May 17, 2024
@asmorkalov asmorkalov changed the title Handle BGRA streams in GStreamer backend WIP: Handle BGRA streams in GStreamer backend May 20, 2024
@asmorkalov asmorkalov modified the milestones: 4.10.0, 4.11.0 May 21, 2024
@asmorkalov asmorkalov changed the title WIP: Handle BGRA streams in GStreamer backend Handle BGRA streams in GStreamer backend Jun 11, 2024
@asmorkalov
Copy link
Contributor Author

@Liedermaus could you try the patch? I changed format priorities a bit to not break existing behavior.

@asmorkalov asmorkalov requested review from opencv-alalek and removed request for MaximMilashchenko June 11, 2024 10:24
@asmorkalov
Copy link
Contributor Author

@opencv-alalek @mshabunin Could you take a look? I fixed regressions and re-order GStreamer caps options.

Copy link
Contributor

@mshabunin mshabunin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me.

I'm wondering whether GRAY should be placed before or after Bayer. If we assume this list is sorted in order of required postprocessing, then GRAY should go before Bayer. And if we assume that color image has higher priority, than GRAY should be last.

@asmorkalov
Copy link
Contributor Author

Color image has higher priority, IMHO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants