-
-
Notifications
You must be signed in to change notification settings - Fork 55.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3rdparty: update libpng 1.6.43 #25580
Conversation
@sturkmen72 Thanks a lot for the update. Brief review summary:
|
@asmorkalov thanks for review. i removed the patch files. |
@fengyuentau @WanliZhong Could you help with Loongarch? |
Do you mean changes in CMake to support new optimizations for loongarch? |
Yes, test locally and ensure that optimizations are enabled correctly. |
@asmorkalov How do I know wheter
|
@fengyuentau thank you for your help and patience. after applying my last commit could you post please all cmake output. |
@asmorkalov @fengyuentau for better testing is it possible temporarily to use https://github.com/opencv/ci-gha-workflow/blob/main/.github/workflows/OCV-PR-4.x-loongnix-loongarch64.yaml |
45a3aa5
to
624011b
Compare
I got this error
|
my bad. i missed include(CheckCCompilerFlag) |
After pulling your fix:
|
@fengyuentau thank you very much for your help. @asmorkalov let me try to add PNG optimization related information in cmake output (to be seen in getBuildInformation()) |
ef4cbdc
to
7325a71
Compare
Looks like we have troubles with ninja-build:
It's used for Android SDK. I'll take a look. |
in my last failed commit it was and now i reverted the change.. lets see if this solves build problem of android.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the contribution! The patch looks good in general. I just fixed a typo.
I propose to modify CMake output a bit and make it similar to libjpeg-turbo.
you mean
or
|
Something like:
|
@asmorkalov @fengyuentau thank you for your help. i think the PR is almost ready to merge. there is still one small issue in my opinion. let me have some time to solve it. |
Made brief performance testing. No changes since previous version. Also build with zlib-ng brings performance gain:
|
new png + zlib-ng on Jetson Orin:
|
I noticed that the "cmake -DCV_DISABLE_OPTIMIZATION=ON" command worked but changing CV_DISABLE_OPTIMIZATION value in cmake-gui did nothing. I looked for a solution to this but couldn't find it. can be looked at later, beyond the scope of this PR. i think the PR is ready to merge. |
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.