fix quantize file types #4502
Merged
fix quantize file types #4502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxyng
force-pushed
the
mxyng/fix-quantize
branch
2 times, most recently
from
882041e
to
6a6d762
Compare
mxyng
force-pushed
the
mxyng/cache-intermediate-layers
branch
from
0aba2d5
to
3520c0e
Compare
pdevine
reviewed
May 20, 2024
server/images.go
Outdated
BruceMacD
reviewed
May 20, 2024
| } | ||
|
|
||
| intermediateBlobs.Store(baseLayer.Layer.Digest, layers[0].Layer.Digest) | ||
| baseLayer.Layer = layers[0].Layer |
There was a problem hiding this comment.
What's the reason for layers being a slice here? To accommodate multimodal models? Im having a bit of trouble easily following all the different layers being passed around.
There was a problem hiding this comment.
That's one reason. The other is to maintain a common interface between this model from a file and model from another model
jmorganca
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes the reported file type (quantization). previously this will report f16 or f32 based on the input file despite going through quantization
this changes contains some changes suggested by @pdevine in #4330