Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tasko): new tasko plugin #12323

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(tasko): new tasko plugin #12323

wants to merge 2 commits into from

Conversation

knid
Copy link

@knid knid commented Apr 4, 2024

Standards checklist:

  • The PR title is descriptive.
  • The PR doesn't replicate another PR which is already open.
  • I have read the contribution guide and followed all the instructions.
  • The code follows the code style guide detailed in the wiki.
  • The code is mine or it's from somewhere with an MIT-compatible license.
  • The code is efficient, to the best of my ability, and does not waste computer resources.
  • The code is stable and I have tested it myself, to the best of my abilities.
  • If the code introduces new aliases, I provide a valid use case for all plugin users down below.

Changes:

  • Created tasko function
  • Created README.md file

Other comments:

...

@ohmyzsh ohmyzsh bot added Area: plugin Issue or PR related to a plugin Type: documentation Documentation issue or Pull Request New: plugin Request for a plugin or Pull Request that adds one labels Apr 4, 2024
@robbyrussell
Copy link
Member

Hi @knid, what are you offering here that isn't currently available in the existing TaskWarrior plugin?

Might this be something we can blend into the existing plugin?

@knid
Copy link
Author

knid commented Jun 11, 2024

Hi @robbyrussell, it's different. The plugin you shared enables tab completion. Mine is opens annotation content with native open commands (xdg-open or open). Like URL or file.

@robbyrussell
Copy link
Member

@knid I'm worried that 'tasko' might not be descriptive enough of a name and if people are using TaskWarrior, they'll see the other. Could we explore merging these two concepts into one?

@knid
Copy link
Author

knid commented Jun 11, 2024

@robbyrussell Taskwarrior uses task cli command. I thought task-open or tasko would be nice. But that's okay for me. We can merge two repo into one.

@knid
Copy link
Author

knid commented Jun 11, 2024

Or i can change repo name to taskwarrior-open

@mcornella
Copy link
Member

Can you show a recording of what your plugin does, for example using asciinema?

It's not clear from reading TaskWarrior docs why xdg-open or open is needed, as according to [1] descriptions are just text-based.

BTW we have a utility function called open_command that uses the right command based on platform/OS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: plugin Issue or PR related to a plugin New: plugin Request for a plugin or Pull Request that adds one Type: documentation Documentation issue or Pull Request
Projects
Status: Waiting reply
Development

Successfully merging this pull request may close these issues.

None yet

3 participants