Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add llvm18 support #3571

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

chenrui333
Copy link

@laytan
Copy link
Sponsor Contributor

laytan commented May 10, 2024

This is a weird one? Why would we need to change things here?

We don't want to run on the latest and greatest llvm in our ci because we also support older versions, and generally wait a bit on upgrading CI/releases.

@chenrui333
Copy link
Author

This is a weird one? Why would we need to change things here?

to match with the homebrew build?

@chenrui333
Copy link
Author

what is the concern here?

@laytan
Copy link
Sponsor Contributor

laytan commented May 10, 2024

This is a weird one? Why would we need to change things here?

to match with the homebrew build?

Alright, but for the reasons I stated in the last comment we don't necessarily want that.

If we were to make the CI use 18, we would probably want a matrix test to do multiple versions.

@chenrui333
Copy link
Author

that is fine, let's do matrix build


note, this is some common practice I am doing to build alliance between upstream and downstream/homebrew

@laytan
Copy link
Sponsor Contributor

laytan commented May 10, 2024

I would be fine with a matrix, I don't have final say here though

Signed-off-by: atlantisbot <lkysow+atlantis@gmail.com>
@chenrui333 chenrui333 changed the title build: llvm 17 -> 18 build: add llvm18 support May 10, 2024
@chenrui333
Copy link
Author

updated to use the matrix build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants