Add zero_to_one parameter to perspective matrix procecures in linalg
#3558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrapperup
force-pushed
the
vk-perspective-matrices
branch
from
361b2a4
to
3994dcb
Compare
wrapperup
force-pushed
the
vk-perspective-matrices
branch
from
3994dcb
to
6f6d1f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a parameter called
zero_to_oneto the existing perspective matrix procs found inlinalg, which are useful in vulkan since the depth range is from 0-1.I made this a draft since I'm not sure about chopping up the matrix definitions up like this. Might be a bit more annoying to reason about. Originally, I had these as different
_zero_to_onesuffixed procs, should we do it that way instead?