Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for project-wide occurrences #1766

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

voodoos
Copy link
Collaborator

@voodoos voodoos commented May 13, 2024

No description provided.

voodoos added a commit to voodoos/merlin that referenced this pull request May 14, 2024
Copy link
Collaborator

@xvw xvw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

String.equal path current_buffer_path
&& Int.equal stamp' stamp ->
&& Int.equal stamp' stamp
&& scope' = scope ->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we benefit to add a Scope.equal (probably written as let equal = (=) in order to try to get rid of = and providing, in a future, an implementation of scopes equality?

@@ -0,0 +1,10 @@
(library
(name merlin_index_format)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the name index_format?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants