New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable colors when stdout is not a terminal. #2634
base: master
Are you sure you want to change the base?
Conversation
Fixes nvm-sh/nvm##2497
Can someone review this … ? |
It looks good, but there's a bunch of tests failing. |
Failure on WSL is a failure from action itself. Failure on travis is quite interesting. But I didn't changed any core codes. I just used Edit: some errors are confusing ... What's
Edit: tested on local machine @ljharb, I think ... travis use It's the same with original nvm using |
When colors are disabled, nvm uses symbols, instead of colors, to convey information. In other words, there may be tests that are expecting the color output, and this change means those tests need to be updated. |
This comment has been minimized.
This comment has been minimized.
All the "fast" and "sourcing" tests are failing. |
Fixes #2497