Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synonyms datamanager #2169

Merged
merged 7 commits into from
May 21, 2024
Merged

Synonyms datamanager #2169

merged 7 commits into from
May 21, 2024

Conversation

jotare
Copy link
Contributor

@jotare jotare commented May 20, 2024

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

@jotare jotare requested a review from a team May 20, 2024 11:50
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 178cc44 Previous: 3f27502 Ratio
nucliadb/search/tests/unit/search/test_fetch.py::test_highligh_error 12882.771024608486 iter/sec (stddev: 0.000001769029848952646) 12969.375444792455 iter/sec (stddev: 1.9097610071932152e-7) 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 76.70%. Comparing base (39cc273) to head (f46904f).
Report is 11 commits behind head on main.

Current head f46904f differs from pull request most recent head 178cc44

Please upload reports for the commit 178cc44 to get more accurate results.

Files Patch % Lines
nucliadb/nucliadb/ingest/orm/knowledgebox.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2169      +/-   ##
==========================================
+ Coverage   76.23%   76.70%   +0.47%     
==========================================
  Files          90       90              
  Lines        6283     6260      -23     
==========================================
+ Hits         4790     4802      +12     
+ Misses       1493     1458      -35     
Flag Coverage Δ
ingest 71.19% <0.00%> (+0.80%) ⬆️
utils 81.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jotare jotare merged commit 3e3be88 into main May 21, 2024
86 checks passed
@jotare jotare deleted the synonyms-datamanager branch May 21, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants