-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vectorsets support to bindings #2162
Add vectorsets support to bindings #2162
Conversation
#[tracing::instrument(skip_all)] | ||
pub fn paragraph_count(&self) -> NodeResult<usize> { | ||
read_rw_lock(&self.paragraph_reader).count() | ||
} | ||
|
||
#[tracing::instrument(skip_all)] | ||
pub fn vector_count(&self) -> NodeResult<usize> { | ||
read_rw_lock(&self.vector_readers) | ||
.get(DEFAULT_VECTORS_INDEX_NAME) | ||
.expect("Default vectors index should never be deleted (yet)") | ||
.count() | ||
} | ||
|
||
#[tracing::instrument(skip_all)] | ||
pub fn text_count(&self) -> NodeResult<usize> { | ||
read_rw_lock(&self.text_reader).count() | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this be removed safely?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, no one was calling this methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: bf028c5 | Previous: 7a0c806 | Ratio |
---|---|---|---|
nucliadb/search/tests/unit/search/test_fetch.py::test_highligh_error |
12975.880162181527 iter/sec (stddev: 3.414487744898704e-7 ) |
13028.091115305282 iter/sec (stddev: 9.732238981112996e-8 ) |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2162 +/- ##
==========================================
- Coverage 76.22% 76.20% -0.03%
==========================================
Files 90 90
Lines 6251 6240 -11
==========================================
- Hits 4765 4755 -10
+ Misses 1486 1485 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Description
Describe the proposed changes made in this PR.
How was this PR tested?
Describe how you tested this PR.